Make sure HeaderFooterPage can contents be scrolled #4704
Conversation
There was a problem hiding this comment.
This is sadly a side-effect of removing the weight(1f) modifier. I'm not sure we can really do something about it 🫤 .
There was a problem hiding this comment.
Actually, I think I found a solution: 33db77f#diff-2214751455c3308dfeb4d6dbe967ae5156c950c3c219e10251a8b95df840080c
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4704 +/- ##
========================================
Coverage 80.11% 80.11%
========================================
Files 2126 2126
Lines 56303 56317 +14
Branches 7021 7022 +1
========================================
+ Hits 45107 45120 +13
Misses 8780 8780
- Partials 2416 2417 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @Composable | ||
| private fun Content( | ||
| state: SecureBackupEnterRecoveryKeyState, | ||
| ) { | ||
| val bringIntoViewRequester = remember { BringIntoViewRequester() } |
There was a problem hiding this comment.
That made the textfield visible, but only half of it (the other half was under the IME).
| ) { | ||
| // Header | ||
| header() | ||
| Box(modifier = Modifier.weight(1f)) { | ||
| Box { | ||
| content() |
There was a problem hiding this comment.
Maybe we should add some padding between the footer and the content? This looks a bit weird without
There was a problem hiding this comment.
Hmm... maybe, but maybe that should be added for the content on each screen? Otherwise we need to remember we have 10-16.dp here and substract it from whatever we have in the designs.
There was a problem hiding this comment.
@ganfra just to remind you of this question: should we add a default padding for all screens and then diff with the designs or leave it at 0 and just apply the padding to each content component so it matches the designs 1:1?
There was a problem hiding this comment.
Can it be a padding on top of the button?
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
Content
.weight(1f)modifier in theHeaderFooterViewcontent wrapper so it can be scrolled.SecureBackupEnterRecoveryKeyViewcomponent when it's focused and the IME opens.TopAppBarcontainer color inFlowStepPagetransparent so the scrolling content is not cut-off by it.Motivation and context
The recovery key screen (and others) was not scrollable anymore, ruining the UX.
Screenshots / GIFs
There are a few screenshots in the PR.
Tests
Tested devices
Checklist